gazebosim/gz-common

igniton-common3 uses string_view with c++11 which is a feature of c++17

Open

#239 opened on Aug 18, 2021

View on GitHubContributor guide
 (2 comments) (0 reactions) (1 assignee)C++ (59 forks)auto 404
bughelp wanted

Repository metrics

Stars
 (28 stars)
PR merge metrics
 (PR metrics pending)

Description

Environment

  • OS Version: Debian Sid, GCC11
  • ign-common3 in debian, version 3.5.0

Description

Steps to reproduce

  1. Install gcc11
  2. Compile code

Not sure how we want to resolve the problem. Seems like the own gtest is using absl::string_view which maybe an alternative until we have ign-common with c++17 enabled.

Contributor guide

Research direction
Investigate the use of `std::string view` in the codebase and ensure it is conditionally compiled only when C++17 is enabled, or replace it with a polyfill like `absl::string view`. Check the CMakeLists.txt for the C++ standard setting.
Tech stack
cpp
Domain
build system
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70