zulip/zulip-terminal

Support receiving message ids to delete in bulk.

Open

#690 opened on Jun 15, 2020

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Python (352 forks)github user discovery
area: event handlinghelp wantedrequires new server feature

Repository metrics

Stars
 (853 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

After https://github.com/zulip/zulip/commit/cda7b2f5393b803f521f45f566b520ebcd9b8d20, client can specify if it supports bulk deletion of messages via passing bulk_message_deletion = True in client_capabilities on /register request.

See do_delete_messages in action.py on zulip/zulip for expected event data formatting in response.

Note that the old event data formatting will be removed in Zulip 2.3 release, so this should be fixed with priority.

Contributor guide

Research direction
Examine the commit that introduced bulk deletion support in the backend (cda7b2f5393b803f521f45f566b520ebcd9b8d20). Update the terminal client's message deletion logic to accept a list of message IDs instead of a single ID when the server advertises bulk deletion capability. Ensure backward compatibility with the old format by checking the 'bulk message deletion' flag in client capabilities. Test with the expected event data format from do delete messages.
Tech stack
python
Domain
cli
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Python
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40