zulip/zulip-terminal

Add/modify specific test(s) to expect a Divider may be in the stream list

Open

#194 opened on Dec 15, 2018

View on GitHub
 (17 comments) (0 reactions) (0 assignees)Python (352 forks)github user discovery
area: testsgood first issuehelp wanted

Repository metrics

Stars
 (853 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

After adding pinned-messages separated by a urwid.Divider(), a few bugs appeared; the Divider is masquerading as a StreamButton, but that should be taken into account, and ideally the tests should have failed when I added the Divider. Based on that, we need more/modified tests for this.

Contributor guide

Research direction
Examine existing tests for stream list views and add test cases that verify Divider appearance and behavior in the stream list, ensuring Divider is not mistaken for StreamButton.
Tech stack
python
Domain
cli
Issue type
Test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Pythonurwidpytest
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65