zulip/zulip-terminal

Use "direct" as the message `type` when sending direct/private messages.

Open

#1,388 opened on Apr 26, 2023

 (11 comments) (0 reactions) (0 assignees)Python (352 forks)github user discovery
api migrationsarea: API specfeature parity: 07help wanted

Repository metrics

Stars
 (853 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Zulip servers (at API feature level 174) support "direct" as the preferred message type for direct/private messages when sending messages and sending typing notifications; see https://github.com/zulip/zulip/pull/25154.

For servers at this feature level, when sending direct messages (POST /messages), Zulip terminal should switch to using the new preferred "direct" value for direct messages.

For typing notifications, the default value was switched from "private" to "direct", so no changes need to be made by clients if the default is being used for direct/private message typing notifications.

See this #api design conversation for more context and discussion on the type parameter.

From that chat.zulip.org conversation related specifically to Zulip terminal:

@_Neil Pilgrim (neiljp)|2406 said:

From a ZT perspective, the post and get valid strings could be left different, or the same and loosened in advance. However, I'm thinking it may be cleaner to have a type which encompasses both, so it may make sense to hold off until the capability is introduced, given 7.0 will be backwards-compatible.

Contributor guide