zulip/zulip-terminal

Two users with the the same name appear as the same person

Open

#1,151 opened on Feb 11, 2022

View on GitHub
 (25 comments) (0 reactions) (0 assignees)Python (352 forks)github user discovery
area: message renderingbuggood first issuehelp wanted

Repository metrics

Stars
 (855 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

On zulip-term version 0.6.0, if two users have the same name and send two messages in sequence within the same topic, the messages will be displayed as if coming from the same user

Contributor guide

Research direction
Examine the code that groups messages by user; likely in the rendering module (e.g., `rendering.py` or `messages.py`). Check if user identity is compared by name instead of a unique ID. Identify where the user display name is retrieved and ensure it uses the user's unique identifier to distinguish between users with the same name.
Tech stack
python
Domain
cli
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitPython
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70