zulip/zulip-mobile

Rename "Night mode" to "Dark theme"

Open

#5,169 opened on Dec 16, 2021

View on GitHubContributor guide
 (32 comments) (0 reactions) (1 assignee)JavaScript (673 forks)github user discovery
a-settingsgood first issuehelp wantedwebapp parity

Repository metrics

Stars
 (1,348 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

In https://github.com/zulip/zulip/issues/20228, we renamed "night mode" to "dark theme" in the web app and the Help center. We should make the mobile app theme name consistent with the web app as well.

Contributor guide

Research direction
Search the codebase for references to 'night mode' or 'night mode' and replace them with 'dark theme' or 'dark theme' accordingly. Update user facing strings and any related variable names or constants. Verify changes in both iOS and Android simulators.
Tech stack
javascriptreact native
Domain
mobile dev
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90