zephyrproject-rtos/zephyr

Bluetooth: VOCS: Client: Use CCC auto discover

Closed

#81,132 opened on Nov 8, 2024

View on GitHubContributor guide
 (1 comment) (0 reactions) (2 assignees)C (9,144 forks)batch import
EnhancementGood first issuearea: Bluetootharea: Bluetooth Audio

Repository metrics

Stars
 (15,249 stars)
PR merge metrics
 (Avg merge 4d 21h) (1,000 merged PRs in 30d)

Description

Is your enhancement proposal related to a problem? Please describe. The VOCS client subscribes to the VOCS state, location and description, but it assumes that the CCC is the next characteristic by hard-coding the handle offset:

	/*
	 * TODO: Don't assume that CCC is at handle + 2;
	 * do proper discovery;
	 */
	sub_params->ccc_handle = attr->handle + 2;

Describe the solution you'd like The VOCS client should perform a proper discovery of the CCC characteristic and subscribe to it, even if it is not at handle + 2. For this the CONFIG_BT_GATT_AUTO_DISCOVER_CCC feature can be used, which is already used in most parts of LE Audio.

Ideally the use of CONFIG_BT_GATT_AUTO_DISCOVER_CCC should re-use the initial discovery parameter struct, so as not to increase memory usage.

Describe alternatives you've considered N/A

Additional context N/A

Contributor guide

Research direction
Investigate the CONFIG BT GATT AUTO DISCOVER CCC option and adapt the VOCS client subscription to use it instead of the hard coded handle offset. Modify the initial discovery parameter struct to reuse memory if possible.
Tech stack
c
Domain
embedded iot
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
BluetoothCZephyr
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65