yugabyte/yugabyte-db

[DocDB] Add validator for consensus_max_batch_size_bytes and rpc_max_message_size flags

Closed

#18,091 opened on Jul 5, 2023

View on GitHub
 (0 comments) (0 reactions) (2 assignees)C (1,003 forks)batch import
area/docdbgood first issuekind/enhancementpriority/medium

Repository metrics

Stars
 (8,229 stars)
PR merge metrics
 (Avg merge 17d 21h) (92 merged PRs in 30d)

Description

Jira Link: DB-7131

Description

Add validator for consensus_max_batch_size_bytes and rpc_max_message_size flags. Similar to rpc_throttle_threshold_bytes https://phorge.dev.yugabyte.com/D26592

Warning: Please confirm that this issue does not contain any sensitive information

  • I confirm this issue does not contain any sensitive information.

Contributor guide

Research direction
Examine the existing validator for rpc throttle threshold bytes (referenced in the issue) to understand the pattern. Locate the flag definitions for consensus max batch size bytes and rpc max message size in the DocDB component (likely under src/yb/docdb/ or src/yb/server/). Implement a similar validator function following the same style, ensuring validation logic matches the intent.
Tech stack
cpp
Domain
backenddatabase
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Blocked
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Familiarity with C++Understanding of flag validators in YugabyteDB
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40