yiisoft/yii2

Preserve a log file's modification time on rotation

Closed

#20,261 opened on Oct 1, 2024

View on GitHubContributor guide
 (10 comments) (2 reactions) (0 assignees)PHP (6,784 forks)batch import
help wantedstatus:ready for adoptiontype:enhancement

Repository metrics

Stars
 (14,302 stars)
PR merge metrics
 (Avg merge 2d 15h) (47 merged PRs in 30d)

Description

What steps will reproduce the problem?

Use Yii's FileTarget enough to cause log file rotation.

What is the expected result?

FS modification time of each log file indicates the date-time when that log file was last written.

What do you get instead?

It indicates when the file was last copied in a rotation.

It is likely enough to add one line to the FileTarget::rotateByCopy() function

        @touch($newFile, filemtime($rotateFile));

Contributor guide

Research direction
Inspect the FileTarget::rotateByCopy() method and add a @touch call to preserve the original file's modification time.
Tech stack
php
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
PHP
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75