yegor256/takes

Improve TkMeasuredTest Coverage (related to #1408)

Open

#1,434 opened on Jul 24, 2025

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Java (215 forks)github user discovery
enhancementhelp wanted

Repository metrics

Stars
 (875 stars)
PR merge metrics
 (Avg merge 95d 2h) (22 merged PRs in 30d)

Description

Refactor and extend TkMeasuredTest to improve coverage and robustness (related to #1408)

The current TkMeasuredTest verifies only the presence of a custom or default header. However, there are several aspects that could be improved:

  1. Add negative/edge test cases:

    • What happens if a null or empty header is passed?
    • Does TkMeasured properly override an existing timing header?

  2. Validate header value:

    • Currently, the tests only assert that the header exists, but not that it contains a valid numeric duration (in ms).

  3. Improve assertion messages:

    • Current failure messages are generic and could be improved with more informative output (e.g. actual value of the response).

This refactor would help ensure better long-term stability and maintainability of the test.

I'm happy to prepare a PR for this if approved.

Contributor guide

Research direction
Review the current TkMeasuredTest to see what it covers, then inspect the TkMeasured class to understand how the timing header is set. Look for edge cases like null or empty headers and how to assert numeric values. Check other test classes for conventions and consider running the tests with Maven.
Tech stack
java
Domain
backendtesting
Issue type
Test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaJUnit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75