yegor256/qulice

Constants should be on the right side of comparison

Open

#716 opened on Feb 16, 2016

View on GitHub
 (6 comments) (0 reactions) (0 assignees)Java (122 forks)github user discovery
bughelp wantedpostponed

Repository metrics

Stars
 (320 stars)
PR merge metrics
 (Avg merge 4d 5h) (68 merged PRs in 30d)

Description

When comparing variables with constants there are two possible approaches: if (null == variable) or if (variable == null)

Let's enforce the second one, so that constant value (string literal, null or number) is on the right side of comparison.

Contributor guide

Research direction
Study existing Checkstyle checks for comparison order (e.g., 'EqualsAvoidNull') and implement a new check that enforces constants on the right side.
Tech stack
java
Domain
developer experiencetooling
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitJava
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70