yarnpkg/yarn

Should not copy `node_modules` of `file:` dependencies

Open

#3,344 opened on May 7, 2017

View on GitHubContributor guide
 (5 comments) (4 reactions) (0 assignees)JavaScript (2,731 forks)batch import
cat-buggood first issuehelp wantedhigh-prioritytriaged

Repository metrics

Stars
 (41,514 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

0.23.4 When we do yarn add file:..path yarn should copy existing contents of node_modules, currently it copies it to cache as well.

Contributor guide

Research direction
Examine the caching logic for file: dependencies in yarn's source code, particularly how node modules is handled during add/link operations.
Tech stack
javascriptnodejs
Domain
clibuild systemdeveloper experience
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
YarnNode.js
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70