xamarin/Xamarin.Forms

[Bug] iOS - ContentLayout ignored if text changed from empty string to text after button rendered

Open

#8,646 opened on Nov 25, 2019

View on GitHubContributor guide
 (3 comments) (3 reactions) (0 assignees)C# (1,926 forks)batch import
e/3 :clock3:help wantedp/iOS 🍎t/bug :bug:up-for-grabs

Repository metrics

Stars
 (5,644 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Description

The ContentLayout of a button is ignored on iOS if the text of the button is changed after the button is initially rendered.

If the button is defined like this in the XAML:

And then the text is changed like this:

Then the button looks like this on iOS:

Screenshot 2019-11-25 at 10 33 12

But it works correctly on Android:

Steps to Reproduce

  1. Start the app on an iOS simulator
  2. Tap the "Change Text" button

Expected Behavior

For both platforms, image should be shown on the right

Actual Behavior

On iOS, the image is shown on the left On Android, the image is shown on the right

Basic Information

  • Version with issue:
  • Last known good version:
  • IDE: Visual Studio for Mac
  • Platform Target Frameworks:
    • iOS: 13.4.0.2
  • Nuget Packages: Xamarin Forms 4.3.991211
  • Affected Devices: iOS devices

Screenshots

(see description)

Reproduction Link

https://github.com/petermajor/ContentLayoutBug

Contributor guide

Research direction
Inspect the iOS Button renderer to understand how ContentLayout is applied when text changes from empty to non empty after initial rendering. Focus on the UpdateContentLayout method and how it interacts with the UIButton's imageEdgeInsets and titleEdgeInsets.
Tech stack
csharpios
Domain
frontendmobile
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Xamarin.FormsiOS development
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40