xamarin/Xamarin.Forms

[Bug] [Shell] SearchHandler in flow direction rtl

Open

#8,517 opened on Nov 15, 2019

View on GitHubContributor guide
 (4 comments) (0 reactions) (0 assignees)C# (1,926 forks)batch import
a/rtla/shell :shell:e/3 :clock3:help wantedp/Androidt/bug :bug:up-for-grabs

Repository metrics

Stars
 (5,644 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Description

When you use the Xamarin.Forms Shell template and make the flow direction of the page from right to left and use SearchHandler it becomes on the left edge But if you make the page flow direction from left to right (default) there is no problem

Steps to Reproduce

  1. Create a fresh Xamarin.Forms Shell project
  2. Enable support rtl in android and add this line code : Window.DecorView.LayoutDirection = LayoutDirection.rtl; in MainActivity.cs
  3. add SearchHandler

Expected Behavior

The SearchHandler design should remain the same even in (rtl) mode

Actual Behavior

Ruined the design in mode (rtl)

Basic Information

  • Version with issue: 4.4.0.991210-pre2
  • Last known good version:
  • IDE: Visual studio 2019 16.3.9
  • Platform Target Frameworks:
    • Android: 9.0 (Pie)
  • Android Support Library Version: 28.0.0.3

Screenshots

RTL : image LTR (Default) : image

Contributor guide

Research direction
Examine how SearchHandler layout handles RTL flow direction in Xamarin.Forms Shell. Look for missing or incorrect layout direction attributes in the SearchHandler control template.
Tech stack
csharpandroid
Domain
mobile
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitXamarin.Forms
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70