xamarin/Xamarin.Forms

[Shell] Entry Focused Event Issue

Open

#8,233 opened on Oct 25, 2019

View on GitHubContributor guide
 (3 comments) (2 reactions) (0 assignees)C# (1,926 forks)batch import
e/3 :clock3:help wantedinactivep/Androidt/bug :bug:up-for-grabs

Repository metrics

Stars
 (5,644 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Description

Event Focused of a entry control is being called even when use entry.UnFocus() in OnDisappearing event.

Steps to Reproduce

  1. Create a screen with one entry control.
  2. Create a Focused event.
  3. Override OnDisappearing method and set Entry.Text = ""; Entry.Unfocus();
  4. Put a breakpoint in the entry_Focused method.
  5. IMPORTANT: Set some value in the entry control. If a value is not be setted the error will not happen.
  6. Choose another screen, anyscreen you want.
  7. Choose the again screen that you created and have the entry.

Expected Behavior

The event focused of the entry control not be called again.

Actual Behavior

The event focused of the entry control is called again. Even when you put Entry.Unfocus(); in the OnDissapearing event.

Basic Information

  • Version with issue: Xamarin.Forms.dll 4.3.0.908675
  • Last known good version: 4.3.0.908675
  • IDE: Visual Studio Professional 2019.
  • Platform Target Frameworks:
    • Android: API 22 above.
  • Android Support Library Version: 5.1 above.
  • Nuget Packages: Xamarin.Forms.dll 4.3.0.908675
  • Affected Devices: Samsung Galaxy S6, S7, S8 Plus, S10 plus, Motorola Moto E Play.

Screenshots

Screenshots attached. ShellFocusIssue.zip

Reproduction Link

https://github.com/JeysonGustavo/ShellEntryFocusedIssue

Contributor guide

Research direction
Reproduce the issue: create a Xamarin.Forms Shell app with an Entry, attach a Focused event, set a value, navigate away and back. Debug to understand why the Focused event is triggered again despite calling Unfocus() in OnDisappearing. Check the lifecycle order: Unfocus() might not work if called after the page has already disappeared. Look into the Entry control's focus management on Android.
Tech stack
csharp
Domain
mobile
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C#Xamarin.Forms
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70