xamarin/Xamarin.Forms

[Bug] Aspect settings not working on MacOS (4.3-pre)

Open

#7,949 opened on Oct 11, 2019

View on GitHubContributor guide
 (12 comments) (1 reaction) (0 assignees)C# (1,926 forks)batch import
e/2 :clock2:help wantedp/macOSt/bug :bug:up-for-grabs

Repository metrics

Stars
 (5,644 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Description

Only 1 of the 3 aspect settings works on XF Mac.

Steps to Reproduce

  1. Create a Xamarin Forms project from template
  2. Add the Mac project to it as per document: https://docs.microsoft.com/en-us/xamarin/xamarin-forms/platform/other/mac
  3. Add image controls to the main page with each aspect setting being used.
  4. Run the app.

Expected Behavior

The expected behavior is demonstrated on iOS: ImageAspectiOS

Actual Behavior

The actual behavior in a MacOS window:

Basic Information

Reproduction Link

ImageAspect.zip

Contributor guide

Research direction
Investigate the commit ce148bf4c81f7d1da5ef74c7a2a43cca6ca73331 and trace the image aspect setting implementation on macOS to identify what was lost.
Tech stack
csharp
Domain
mobile
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C#Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70