xamarin/Xamarin.Forms

[Bug] Top and Bottom padding on Material button can't be set to less than 8dp

Open

#7,860 opened on Oct 7, 2019

View on GitHubContributor guide
 (2 comments) (2 reactions) (0 assignees)C# (1,926 forks)batch import
a/visuale/3 :clock3:help wantedt/bug :bug:up-for-grabs

Repository metrics

Stars
 (5,644 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Description

        <StackLayout Visual="Material">
            <Button  Padding="0" Text="no padding" ></Button>
            <Button  Text="default"></Button>
        </StackLayout>

Both of the controls above render with the same padding applied to the control so you can't get a 36 dp height on a Material Button (which is allowable as part of the Material spec)

Expected Behavior

When you set padding to zero the padding on all side of the control should be zero

Actual Behavior

It's not zero

Basic Information

  • Version with issue: master (I also tested with Android X)

Contributor guide

Research direction
Inspect the Material button renderer implementation in Xamarin.Forms to find where the minimum padding (8dp) is enforced and how to make it configurable.
Tech stack
csharp
Domain
mobile
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C#Xamarin.Forms
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65