xamarin/Xamarin.Forms

[Bug] Text on disabled button loses center alignment on keyboard open after updating XF to 4.2.0.848062

Open

#7,824 opened on Oct 4, 2019

View on GitHubContributor guide
 (7 comments) (1 reaction) (0 assignees)C# (1,926 forks)batch import
4.2.0a/fastrenderershelp wantedi/regressionp/Androidt/bug :bug:up-for-grabs

Repository metrics

Stars
 (5,644 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Description

I updated my XF app from 4.1 to 4.2 and now when I open keyboard text on disabled button on screen is moved to left, after keyboard is closed text alignment restores, and on subsequent keyboard open text remains centered.

Steps to Reproduce

I don't know how to reproduce,

Expected Behavior

Button text at center.

Actual Behavior

Button text aligned left.

Basic Information

  • Version with issue: 4.2.0.848062
  • Last known good version: 4.1.0.581479
  • IDE: Visual Studio 16.3.1, debug build
  • Platform Target Frameworks:
    • Android: 9.0
  • Android Support Library Version: 28.0.0.3
  • Nuget Packages:
  • Affected Devices: Huawei U5

Screenshots

photo_2019-10-04_17-44-53

photo_2019-10-04_17-45-03

Reproduction Link

When I create custom button renderer inherited from Xamarin.Forms.Platform.Android.ButtonRenderer it fixes button text behavior, when I inherit renderer from Xamarin.Forms.Platform.Android.FastRenderers.ButtonRenderer bug returns.

Contributor guide

Research direction
Investigate the difference between the two Button renderers (FastRenderers vs classic) on Android. Focus on the layout update logic during keyboard open/close events.
Tech stack
csharpandroid
Domain
mobile
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
GitC#
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50