xamarin/Xamarin.Forms

[Bug] [iOS] CheckBox SetImage(UIControlState.Normal) had no effect

Open

#7,180 opened on Aug 16, 2019

View on GitHubContributor guide
 (2 comments) (0 reactions) (0 assignees)C# (1,926 forks)batch import
a/customrenderere/5 :clock5:help wantedp/iOS 🍎t/bug :bug:up-for-grabs

Repository metrics

Stars
 (5,644 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Description

SetImage() method in CheckBoxRender doesn't set Image for Normal state.

Steps to Reproduce

  1. Create Xamarin.Forms 4.1 project.
  2. Create a custom checkbox and place it on view.
  3. Add CheckBoxRenderer in the iOS project for the created checkbox.
  4. Set two image for Normal and Selected state's.
  5. Add code below to set Selected state for Control:
         Element.CheckedChanged += (s, ev) =>
         {
            Control.Selected = Element.IsChecked;
         };
  1. Run the app. Check and uncheck the checkbox.

Expected Behavior

The checkbox in a Normal state does not have a default icon.

Actual Behavior

The checkbox in a Normal state has a default icon.

Basic Information

  • Version with issue: 4.1.x
  • Visual Studio Enterprise 2019 Version 16.0.3
  • Xamarin.iOS Version: 12.8.0.2

Reproduction Link

https://github.com/TarasBounty/XamFormsCheckboxImage

Contributor guide

Research direction
Investigate the iOS CheckBoxRenderer's SetImage method to understand why the image for UIControlState.Normal is not being applied. Check if there is a missing call or condition that prevents setting the image for that state.
Tech stack
csharp
Domain
mobile
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Xamarin.Forms
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70