xamarin/Xamarin.Forms

[Bug] On iOS, menu button of MasterDetailPage disappears when using NavigationPage's InsertPageBefore and PopToRootAsync

Open

#7,051 opened on Aug 2, 2019

View on GitHubContributor guide
 (6 comments) (0 reactions) (0 assignees)C# (1,926 forks)batch import
e/1 :clock1:hacktoberfest 🍻help wantedin-progressp/iOS 🍎t/bug :bug:up-for-grabs

Repository metrics

Stars
 (5,644 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Description

On iOS, when using a MasterDetailPage, the "menu" button disappears when using NavigationPage's InsertPageBefore and PopToRootAsync to switch Detail page. No issue on Android, the "menu" icon does not disappear. A workaround on iOS consists in creating a new NavigationPage when switching the Detail page, but it causes a flickering issue on Android.

Steps to Reproduce

  1. On iOS, create a MasterDetailPage. The Detail page should be a NavigationPage. Open the app, the menu button is displayed and the menu opens when the user clicks on the button.
  2. Switch the Detail page by using a combination of InsertPageBefore and PopToRootAsync on the NavigationPage. The menu button disappears.

Expected Behavior

The menu button should not disappear, since the app's MainPage is the same MasterDetailPage with the same Master and the same Detail's NavigationPage. On Android, the hamburger icon does not disappear.

Actual Behavior

The menu button disappears.

Basic Information

  • Version with issue: XF 4.1
  • Last known good version: I'm not sure it has ever worked
  • IDE: VS 2019 16.2.0
  • Platform Target Frameworks: iOS 12.4

Reproduction Link

TestIos.zip

Contributor guide

Research direction
Investigate the iOS renderer for MasterDetailPage and NavigationPage. Focus on the behavior when InsertPageBefore and PopToRootAsync are called on the NavigationPage. Check if the menu button hiding is related to UINavigationItem or UIBarButtonItem updates. Look at the Xamarin.Forms source code for the iOS custom renderer and identify where the menu button visibility is set. A good starting point is the Xamarin.Forms.Platform.iOS project: MasterDetailRenderer and NavigationRenderer. Trace the flow of InsertPageBefore and PopToRootAsync to see if they inadvertently reset the navigation bar or the master button.
Tech stack
csharp
Domain
mobile
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitXamarin.FormsiOS development
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
55