xamarin/Xamarin.Forms

[Bug] Color of FontImageSource does not change when Button is disabled

Open

#6,836 opened on Jul 10, 2019

View on GitHubContributor guide
 (5 comments) (0 reactions) (0 assignees)C# (1,926 forks)batch import
a/stylee/4 :clock4:help wantedt/bug :bug:up-for-grabs

Repository metrics

Stars
 (5,644 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Description

When a button which contains a FontImageSource and a text is disabled, only the text takes a different disabled color, not the fontImageSource.

Steps to Reproduce

  1. Create a button with an FontImageSource as the ImageSource and a text
  2. Disable the button
  3. The color of the text is changed but not the color of the icon of the FontImageSource

Expected Behavior

Both the text and the icon should have the same disabled color.

Actual Behavior

Only the text has a disabled color, not the icon.

Basic Information

  • Version with issue: Xamarin Forms 4.1
  • IDE: VS 2019

Screenshots

image

Contributor guide

Research direction
Examine the Button renderer for iOS and Android to see how FontImageSource color is applied when disabled. Look for the code that updates the icon color and compare it to how the text color is handled. Consider if the FontImageSource needs to update its color based on the disabled state.
Tech stack
csharp
Domain
mobile
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C#Xamarin.Forms
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60