xamarin/Xamarin.Forms

[Bug] [iOS] unset font properties on a Span are not inherited if any font property is set

Open

#6,734 opened on Jul 1, 2019

View on GitHubContributor guide
 (5 comments) (0 reactions) (0 assignees)C# (1,926 forks)batch import
e/5 :clock5:help wantedinactivep/iOS 🍎t/bug :bug:up-for-grabs

Repository metrics

Stars
 (5,644 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Description

If any font property is set on a span, all other properties will have default value instead of those inherited from owner Label (click link to source)

Steps to Reproduce

  1. create a label with fontattributes italic
  2. add a formattedstring with span fontsize set to large

the span will be large but not italic

Expected Behavior

inherit unset font properties from label.

Actual Behavior

unset font properties are default values.

Basic Information

  • Version with issue: 3.6
  • Platform Target Frameworks:
    • iOS: 12.3

Contributor guide

Research direction
Inspect the file `FormattedStringExtensions.cs` on line 92 to understand how font properties are inherited from the Label to the Span. Focus on the logic that sets font attributes and verify why unset properties fall back to default values instead of inheriting from the Label.
Tech stack
csharp
Domain
mobile
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Xamarin.FormsiOS development
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70