xamarin/Xamarin.Forms

[Bug, Core] incorrect reset CornerRadius of Button

Open

#6,731 opened on Jul 1, 2019

View on GitHubContributor guide
 (0 comments) (0 reactions) (0 assignees)C# (1,926 forks)batch import
4.0.0e/3 :clock3:help wantedi/regressioninactivet/bug :bug:up-for-grabs

Repository metrics

Stars
 (5,644 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Description

When resetting of CornerRadius first time it sets radius value 5. Second reset sets radius to -1.

Steps to Reproduce

  1. ControlGallery
  2. Dynamic ViewGallery
  3. Control: Button
  4. Set CornerRadius
  5. Reset CornerRadius
  6. Again reset CornerRadius

Expected Behavior

The reset value should not depend on its current value.

Actual Behavior

First reset of CornerRadius sets corner radius to 5. Second reset of CornerRadius removes radius.

Contributor guide

Research direction
Investigate the CornerRadius property reset logic in ButtonRenderer or related code. Check the default value and how reset behavior is implemented.
Tech stack
csharp
Domain
mobile
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C#Xamarin.Forms
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60