xamarin/Xamarin.Forms

[Bug] TapGestureRecognizer on iOS with Material Visual

Open

#6,521 opened on Jun 13, 2019

View on GitHubContributor guide
 (4 comments) (0 reactions) (0 assignees)C# (1,926 forks)batch import
4.0.0e/3 :clock3:help wantedi/regressioninactivep/iOS 🍎t/bug :bug:up-for-grabs

Repository metrics

Stars
 (5,644 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Description

upgrading to 4.0.0.497661 breaks TapGestureRecognizer only tested on android

Steps to Reproduce

sample xaml (parent is stacklayout) <views:ClientCardView BindingContext="{Binding Client}"> <views:ClientCardView.GestureRecognizers> <TapGestureRecognizer Command="{Binding BindingContext.SelectClientCommand, Source={x:Reference taskItemPage}}" /> </views:ClientCardView.GestureRecognizers> </views:ClientCardView>

rolling back to 482894 fixes the issue.

Expected Behavior

tapping on the element should execute the command

Actual Behavior

Basic Information

  • Version with issue: 497661
  • Last known good version: 482894
  • IDE: VS 2017 Windows

Contributor guide

Research direction
Compare the changes between commit 482894 and 497661 in Xamarin.Forms repository, specifically in the codebase related to TapGestureRecognizer and Material Visual renderer on iOS. Trace the handler path to identify the breaking change.
Tech stack
csharp
Domain
mobile
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70