xamarin/Xamarin.Forms

[Bug] OnPlatform doesnt work with Comma separated values

Open

#6,048 opened on Apr 30, 2019

View on GitHubContributor guide
 (4 comments) (0 reactions) (0 assignees)C# (1,926 forks)batch import
a/Xaml </>e/1 :clock1:hacktoberfest 🍻help wantedt/bug :bug:up-for-grabs

Repository metrics

Stars
 (5,644 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Description

if i want to define padding or margin with multiple values onplatform like below. it doesnt work. I guess that comma is confused with comma between platform definitions.

Padding="{OnPlatform iOS=0,30,0,0, Default=0}"

Steps to Reproduce

  1. define padding on anything like Padding="{OnPlatform iOS=0,30,0,0, Default=0}"

Expected Behavior

it recognises padding or margin

Actual Behavior

no error but not working at all.

Basic Information

  • Version with issue:
  • Last known good version:
  • IDE: vs 2019
  • Platform Target Frameworks:
    • iOS: 12.2
    • Android:
    • UWP:
  • Android Support Library Version:
  • Nuget Packages:
  • Affected Devices:

xamarin forms:3.6

Contributor guide

Research direction
Investigate the XAML markup extension parsing logic for OnPlatform to handle values containing commas.
Tech stack
csharp
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C#XAML
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65