xamarin/Xamarin.Forms

Item height of the listview is not auto size when load image with aspect fill

Open

#5,748 opened on Mar 29, 2019

View on GitHubContributor guide
 (2 comments) (0 reactions) (0 assignees)C# (1,926 forks)batch import
a/listviewe/7 :clock7:help wantedinactivep/Androidt/bug :bug:up-for-grabs

Repository metrics

Stars
 (5,644 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Description

Row height of the listview is not updated when load image inside the item template of the listview with Aspect as AspectFill.

Same issue replicated in SFListVIew also.

Steps to Reproduce

  1. Run the sample and navigate to Xamarin ListView
  2. You can see that the row height is not properly calculated and image is not shown properly.

Expected Behavior

Image should visible with proper height.

Actual Behavior

Image is clipped

Basic Information

  • Version with issue: 3.5.0.169047
  • Last known good version:
  • IDE: VS2017
  • Platform Target Frameworks:
    • iOS:
    • Android:
    • UWP:
  • Android Support Library Version:
  • Nuget Packages:
  • Affected Devices:

Screenshots

Screenshot_20190329-174439

Reproduction Link

Sample.zip

Contributor guide

Research direction
Investigate the ListView item height calculation when using AspectFill for images. Check the layout cycle and how the image size affects the row height. Look into the Xamarin.Forms source code for ListView and Image rendering.
Tech stack
csharp
Domain
mobile
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Xamarin.FormsC#
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50