xamarin/Xamarin.Forms

Memory leak when UWP toolbar has too many items to show in one horizontal bar

Open

#5,438 opened on Mar 4, 2019

 (0 comments) (0 reactions) (0 assignees)C# (1,926 forks)batch import
e/5 :clock5:help wantedinactivep/UWPt/bug :bug:up-for-grabs

Repository metrics

Stars
 (5,644 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Description

Using XF 3.4.0.1008975, on UWP, with a ContentPage that has a Toolbar with multiple primary ToolbarItems, reduce the width of the window for the app until ToolbarItems are automatically moved from the horizontal toolbar to the dropdown that appears when the ellipsis/more button is pressed. Drop down the menu to see the items there. Now navigate back to the previous page by hitting the Navigation Back button. The memory associated with the ContentPage with the dropdown toolbar items is never finalized.

Steps to Reproduce

  1. With an app with a NavigationPage for the main page, and a second ContentPage with a number of ToolbarItems, and with that ContentPage having a finalizer, put a breakpoint in the finalizer
  2. Follow the sequence in the description above
  3. Check whether the breakpoint is ever hit

Expected Behavior

The breakpoint in the finalizer should be hit

Actual Behavior

The breakpoint in the finalizer is not hit

Basic Information

  • Version with issue: 3.4.0.1008975
  • Last known good version: Unknown
  • IDE: VS 2017
  • Platform Target Frameworks:
    • UWP: 16299
  • Affected Devices: Windows 10 desktop

Screenshots

Reproduction Link

Contributor guide