xamarin/Xamarin.Forms

[iOS] TextColor on Span's Implicit Style affects SearchBar PlaceholderColor

Open

#5,355 opened on Feb 23, 2019

View on GitHubContributor guide
 (2 comments) (0 reactions) (0 assignees)C# (1,926 forks)batch import
e/2 :clock2:good first issuehelp wantedi/lowinactivep/iOS 🍎t/bug :bug:up-for-grabs

Repository metrics

Stars
 (5,644 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Description

Setting the Spans TextColor from an implicit style in the App.xaml makes all SearchBars have that color in their Placeholder.

Steps to Reproduce

  1. Put this in the App.xaml
<Style TargetType="Span">
    <Setter Property="TextColor" Value="Red" />
</Style>
  1. Put this in the main page:
<SearchBar Placeholder="Search..." PlaceholderColor="Green" />

Expected Behavior

Green placeholder.

Actual Behavior

Red placeholder.

Basic Information

  • Version with issue: happens since TextColor in Span was introduced in XF 3.1
  • Last known good version: N/A
  • Platform Target Frameworks:
    • iOS: 12.1
    • Android: N/A
    • UWP: N/A

Screenshots

Reproduction Link

https://drive.google.com/open?id=1U9uVOpJ7HalQJZK_I6ZH0Xck5yC9kHsw

Contributor guide

Research direction
Investigate how the iOS SearchBar renderer applies placeholder color and ensure it does not pick up the implicit Span TextColor style.
Tech stack
csharp
Domain
mobile
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C#Xamarin.Forms
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40