xamarin/Xamarin.Forms

[Feedback] Xamarin Forms ContentPresenter doesn't display correctly in Right-to-Left after rotation

Open

#5,025 opened on Jan 18, 2019

View on GitHubContributor guide
 (4 comments) (1 reaction) (0 assignees)C# (1,926 forks)batch import
a/rtle/4 :clock4:feedback-tickethelp wantedp/Androidp/iOS 🍎t/bug :bug:up-for-grabs

Repository metrics

Stars
 (5,644 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Description

If you create a custom ContentView with a control template, the content assigned to the control does not display correctly after rotation if the FlowDirection is set to RightToLeft - regardless of whether it is from the device or if it is set explicitly.

On both iOS and Android (haven’t tested Windows yet), the contents shift to the right, extending past the edge of the screen.

Steps to Reproduce:

  1. Create a plain Xamarin Forms project supporting iOS and Android (and probably Windows)
  2. Create a new Forms ContentView XAML object
  3. Add a ControlTemplate with a ContentPresenter
  4. In MainPage.xaml, put the newly created ContentView onto the page
  5. Put content into the ContentView
  6. Change the FlowDirection to Right-to-Left
  7. Run the app and rotate it

A sample that reproduces the problem can be found here: https://www.dropbox.com/s/3pak9ighagqzlr4/XamarinFormsTest.zip?dl=0 View on Developer Community To find diagnostic information, see the original linked feedback ticket.

Source

772674

Contributor guide

Research direction
Investigate the ContentPresenter layout behavior during rotation when FlowDirection is RightToLeft. Check if there is an issue with measurement or arrange that causes content to shift right. Look at the layout cycle and consider overriding methods to force correct layout.
Tech stack
csharp
Domain
mobile
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Xamarin.Forms basicsLayout and control templates
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60