xamarin/Xamarin.Forms

NavigationPage.SetHasNavigationBar bar is broken for TabbedPage(MasterDetailPage too?) on UWP

Open

#4,531 opened on Nov 26, 2018

View on GitHubContributor guide
 (6 comments) (7 reactions) (0 assignees)C# (1,926 forks)batch import
e/4 :clock4:help wantedm/high impact :black_large_square:p/UWPt/bug :bug:up-for-grabs

Repository metrics

Stars
 (5,644 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Description

There was an original issue for MasterDetailPage - it marked as closed however this issue is still persists atleast on TabbedPage (there are report in original issue that it is still broken for MDP too). Since the issue is not reopened yet I've created separate issue. If you have ContentPage (with NavigationPage.SetHasNavigationBar=false) wrapped in Navigation page as child of TabbedPage - navigating to this page causes to show preserved space for NavigationBar (but bar itself is not visible).

Steps to Reproduce

  1. Run attached project.
  2. NavigationBar on the first tab is hidden.
  3. Navigate to the second tab.
  4. Navigate back to the first tab.

Expected Behavior

Navigation bar is not visible, there is no preserved space at the top of the page. 1

Actual Behavior

Navigation bar is not visible, there is preserved space at the top of the page. 2

Basic Information

  • Version with issue: 3.4.0.1008975

  • IDE: Visual Studio 2017 15.9.0

  • Platform Target Frameworks:

    • UWP: 16299

TabbedPageNavBarIssue.zip

Contributor guide

Research direction
Investigate the TabbedPage rendering on UWP to find why NavigationPage.SetHasNavigationBar(false) leaves a blank space after tab switching. Look for layout update logic in the native renderer.
Tech stack
csharp
Domain
mobile
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitC#
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70