xamarin/Xamarin.Forms

iOS - Icon in Detail of MasterDetail wrong after rotation

Open

#4,506 opened on Nov 21, 2018

View on GitHubContributor guide
 (4 comments) (0 reactions) (0 assignees)C# (1,926 forks)batch import
e/3 :clock3:help wantedi/highinactivep/iOS 🍎t/bug :bug:up-for-grabs

Repository metrics

Stars
 (5,644 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Description

We have a MasterDetailPage that is set to SplitOnLandscape. The detail page is a navigation page. If we add a page to the detail navigation stack, rotate the device, then use the back arrow in the detail page the icon in the detail is off. If you off in landscape, upon rotation to portrait and going back the icon will be gone entirely. if you started in portrait upon rotation and going back a hamburger icon will appear.

Steps to Reproduce

  1. Create MasterDetailPage with navigation page in detail
  2. push new page in detail navigation page
  3. rotate the device and go back.

Expected Behavior

No icon should be visible when in landscape and a Hamburger should be available in portrait

Actual Behavior

No icon in portrait and hamburger in landscape

Screenshots

image from ios

Contributor guide

Research direction
Reproduce the issue with a MasterDetailPage set to SplitOnLandscape. Push a page onto the detail navigation stack, rotate the device, and use the back arrow. Investigate how the navigation bar icon is updated during rotation and navigation events. Trace the Xamarin.Forms iOS renderer code for MasterDetailPage and NavigationPage to identify the source of the discrepancy.
Tech stack
csharp
Domain
mobile
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Xamarin.FormsiOS development
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60