xamarin/Xamarin.Forms

iOS tabbed page shows edit button after screen rotation

Open

#4,441 opened on Nov 16, 2018

View on GitHubContributor guide
 (3 comments) (0 reactions) (0 assignees)C# (1,926 forks)batch import
e/4 :clock4:help wantedinactivep/iOS 🍎t/bug :bug:up-for-grabs

Repository metrics

Stars
 (5,644 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Description

During a manual monkey test we discovered that on iOS the tabbed page's overflow menu sometimes shows an "Edit" button which is not functional.

Steps to Reproduce

  1. Create a tabbed page with more than 5 sub pages
  2. Open the app in portrait
  3. Open the overflow menu (notice the absence of an "edit" button)
  4. Rotate the phone in landscape (The overflow menu now also closes which is undesirable on itself)
  5. Open the overflow menu again (It now shows a non functional edit button)

Expected Behavior

No edit button

Actual Behavior

A edit button

Basic Information

  • Version with issue: 3.3
  • Last known good version: -
  • IDE: VS 2017
  • Platform Target Frameworks:
    • iOS: 12.1
  • Affected Devices: iPhone

Screenshots

Here two screenshots, one before rotation and one after rotation

Before rotation

image

After rotation

image

Contributor guide

Research direction
Investigate the iOS tabbed page's overflow menu behavior on rotation. Look into the Xamarin.Forms renderer for TabbedPage on iOS, specifically the MoreNavigationController, to determine why an edit button appears after rotation.
Tech stack
csharp
Domain
mobile
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C#Xamarin.FormsiOS
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75