xamarin/Xamarin.Forms

Timepicker events are not fired for the first time in xamarin.forms verison 3.3. Until version 3.2.0.871581 it was working as expected

Open

#4,419 opened on Nov 15, 2018

View on GitHubContributor guide
 (1 comment) (0 reactions) (0 assignees)C# (1,926 forks)batch import
3.3.0e/5 :clock5:help wantedi/regressioninactivet/bug :bug:up-for-grabs

Repository metrics

Stars
 (5,644 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Description

I have defined a renderer for the TimePicker (Android). Whenever i tried to change the time , the events are not fired only for the first time. For the subsequent time change events are firing. Until Xamarin.forms version 3.2.0.871581, it was working as expected. This changed after update to version 3.3

Attaching the Sample for details. TImePickerSample.zip

Steps to Reproduce

  1. Click on the timepicker
  2. Select time and click OK
  3. Event not called for the first time.

Expected Behavior

The event should be called as required

Actual Behavior

Event isnt Fired for the first time. For the subsequent time change, the event is fired

Basic Information

Xamarin.forms 3.3 Android FormsApplicationActivity

  • Version with issue: Xamarin.forms 3.3 Platform Target Frameworks:
    • Android: The version of the Android SDK i am compiling against, 8.1
  • Affected Devices: Android

Last Known good version: With Xamarin.forms version 3.2.0.871581, it was working as expected. This changed after update to version 3.3

Screenshots

Reproduction Link

Contributor guide

Research direction
Compare the TimePicker renderer implementation between Xamarin.Forms versions 3.2 and 3.3 to identify what changed regarding event firing. Specifically, look at the Android TimePickerRenderer source code to find why the first time selection does not trigger the property changed event.
Tech stack
csharpandroid
Domain
mobile
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Visual StudioXamarin.FormsAndroid SDK
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70