xamarin/Xamarin.Forms

[iOS] Wrong Page Height when Navigation Bar is Hidden

Open

#3,932 opened on Sep 28, 2018

View on GitHubContributor guide
 (1 comment) (0 reactions) (0 assignees)C# (1,926 forks)batch import
e/4 :clock4:help wantedinactivep/iOS 🍎t/bug :bug:up-for-grabs

Repository metrics

Stars
 (5,644 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Description

it seems xamarin.forms used wrong page height if hide navigation bar.

as my example:

  1. when show navigation bar, there is safeAreaInsets at bottom, and 3 point for margin. which works great simulator screen shot - iphone x - 2018-09-28 at 17 17 27

  2. however, if hide the navigation bar, it will show like this: simulator screen shot - iphone x - 2018-09-28 at 17 17 43 safeAreaInsets and margin-bottom is missing.

it seems because of wrong page height.

Expected Behavior

safeAreaInsets and margin-bottom should be there when hide navigation bar.

Screenshots

https://user-images.githubusercontent.com/211855/46199903-d09ce080-c342-11e8-814a-e6d1ce9167ae.png https://user-images.githubusercontent.com/211855/46200034-2f625a00-c343-11e8-8e48-a9a727f80fe2.png

Reproduction Link

navgation-page-demo.zip

Contributor guide

Research direction
Investigate the layout logic in Xamarin.Forms that calculates page height on iOS when NavigationPage.HasNavigationBar is false. Focus on how safe area insets and bottom margins are applied.
Tech stack
csharp
Domain
mobile
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Xamarin.FormsiOS development
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30