xamarin/Xamarin.Forms

Page.UseSafeArea="true" not respected on all pages inside a CarouselPage

Open

#3,837 opened on Sep 19, 2018

View on GitHubContributor guide
 (1 comment) (0 reactions) (0 assignees)C# (1,926 forks)batch import
a/layoute/4 :clock4:help wantedinactivet/bug :bug:up-for-grabs

Repository metrics

Stars
 (5,644 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Description

When creating a CarouselPage with more than 2 ContentPages within it. The Page.UseSafeAre is only respected on the first two pages.

Steps to Reproduce

  1. Create an empty Xamarin.Forms project
  2. Change the MainPage to a CarouselPage
  3. Add more than 2 ContentPages, with each ContentPage having this: xmlns:ios="clr-namespace:Xamarin.Forms.PlatformConfiguration.iOSSpecific;assembly=Xamarin.Forms.Core" ios:Page.UseSafeArea="true" and some content on it.
  4. Start iOS simulator for an iPhone X(s/r)

Expected behavior

It should be expected that the "notch" area will be discarded and that the content starts below it.

Actual Behavior

For the first two pages the notch area is discarded. But for every other page it is not.

Basic Information

Xamarin.Forms 3.2.0.839982 Simulator device: iPhone XR iOS 12.0

Screenshots

First two pages:

Every other page:

Contributor guide

Research direction
Check the iOS renderer for CarouselPage and how it handles safe area for child pages. It likely only initializes safe area for the first two pages (preloaded). Examine page lifecycle events and ensure safe area is applied when pages become visible.
Tech stack
csharp
Domain
mobile
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitC#
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70