xamarin/Xamarin.Forms

async TapGestureRecognizer wrong signature

Open

#3,818 opened on Sep 18, 2018

View on GitHubContributor guide
 (3 comments) (0 reactions) (1 assignee)C# (1,926 forks)batch import
3.2.0a/Xaml </>a/buildchaine/5 :clock5:help wantedi/regressioninactivet/bug :bug:up-for-grabs

Repository metrics

Stars
 (5,644 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Description

my project ain't compiling since upgrading from 3.1 to 3.2

Steps to Reproduce

<Image Source="image.png">
    <Image.GestureRecognizers>
        <TapGestureRecognizer Tapped="OnClicked"/>
    </Image.GestureRecognizers>
</Image>

private async Task OnClicked(object sender, EventArgs args) // error
private void OnClicked(object sender, EventArgs args) // ok

Contributor guide

Research direction
Investigate the event handler signature requirement for TapGestureRecognizer. Check if async Task is supported or if it must be void.
Tech stack
csharp
Domain
mobile
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C#Xamarin.Forms
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70