xamarin/Xamarin.Forms

[Android] Image on Button is not centered with text

Open

#3,527 opened on Aug 9, 2018

View on GitHubContributor guide
 (15 comments) (4 reactions) (0 assignees)C# (1,926 forks)batch import
a/buttone/3 :clock3:help wantedinactivep/Androidt/bug :bug:up-for-grabs

Repository metrics

Stars
 (5,644 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Description

The Image is not in the center on Button when displaying with a text.

Steps to Reproduce

  1. Create a Button with an image & text.
  2. Set thee HorizontalOption to Fill&Expand.
  3. You can see that the image is stick to the left border
  4. If you change the position(Top,Right...) of the image it will stick on the position selected, not centered with the text

Expected Behavior

The image have to stick the text on the center.

Actual Behavior

The Image is stick to the border depends of the selected position. I was searching a way to make a correction on UpdateBitmap But PropertyName "Image" never pass to UpdateBitmap

        protected override void OnElementPropertyChanged(object sender, PropertyChangedEventArgs e)
        {
            if (e.PropertyName == Button.TextProperty.PropertyName)
                UpdateBitmap();

            base.OnElementPropertyChanged(sender, e);
        }

Basic Information

  • Xamarin.Forms: 3.1.0.697729
    • Android: 8.1

Contributor guide

Research direction
Investigate the Android ButtonRenderer in Xamarin.Forms to understand how image and text are laid out. Focus on the OnElementPropertyChanged method and how the Image property is handled. Look for alignment or layout logic that might cause the image to stick to the edge instead of being centered with text.
Tech stack
csharpandroid
Domain
mobile
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C#Xamarin.FormsAndroid
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60