xamarin/Xamarin.Forms

Slider overwrites value when attributes in wrong order

Open

#3,521 opened on Aug 9, 2018

View on GitHubContributor guide
 (2 comments) (0 reactions) (0 assignees)C# (1,926 forks)batch import
e/7 :clock7:help wantedinactivet/bug :bug:up-for-grabs

Repository metrics

Stars
 (5,644 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Description

Slider overwrites the provided value when Xaml attributes in wrong order.

Steps to Reproduce

  1. Add a Slider to your Xaml with Value attribute followed by Maximum and/or Minimum attribute.
  2. Provided value will be ignored, 1 will be used as default value.

Expected Behavior

Provided value is used, regardless of order of attributes.

Actual Behavior

Provided value is overwritten with 1.

Basic Information

  • Version with issue: 3.1.0.697729
  • Last known good version: -
  • IDE: Visual Studio for Mac
  • Platform Target Frameworks:
    • iOS: 11.4
    • Android: 8.1
    • UWP: -
  • Android Support Library Version: 27.0.2.1
  • Nuget Packages: Xamarin.Forms 3.1.0.697729
  • Affected Devices: reproduced on iPhone X and Samsung Galaxy S6

Reproduction Link

SliderIssue.zip

Contributor guide

Research direction
Investigate the order of property setting in XAML parsing for Slider. Check if Value is set before Minimum and Maximum, causing it to be clamped to default range. Consider adding logic to defer Value setting until after Minimum and Maximum are set.
Tech stack
csharp
Domain
mobile
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Xamarin.FormsC#XAML
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50