xamarin/Xamarin.Forms

SelectionMode None keep the highlighting and Ripple

Open

#3,463 opened on Aug 2, 2018

View on GitHubContributor guide
 (5 comments) (5 reactions) (0 assignees)C# (1,926 forks)batch import
a/listviewe/3 :clock3:help wantedp/Androidp/iOS 🍎t/bug :bug:up-for-grabs

Repository metrics

Stars
 (5,644 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Description

When we set the SelectionMode to None, we still have the Highlighting color on iOS and the Ripple effect on android

Steps to Reproduce

  1. Set a ListView
  2. Set the SelectionMode to None
  3. Touch an Item

Expected Behavior

Nothing append

Actual Behavior

iOS : We see the Highlighting color Android : we see the Ripple effect

Basic Information

  • Version with issue: 3.1
  • IDE: Visual Studio Mac

Contributor guide

Research direction
Look at the platform specific renderers for ListView in Xamarin.Forms. On iOS, check the `ListViewRenderer` for how `SelectionMode.None` is handled and ensure that highlighting is suppressed. On Android, examine the `ListViewRenderer` to disable the ripple effect when selection mode is None.
Tech stack
csharp
Domain
mobile
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Needs maintainer response
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Xamarin.FormsiOS developmentAndroid development
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
55