xamarin/Xamarin.Forms

[iOS] Secondary Toolbar Items are not centered

Open

#3,457 opened on Aug 1, 2018

View on GitHubContributor guide
 (3 comments) (0 reactions) (0 assignees)C# (1,926 forks)batch import
e/4 :clock4:help wantedinactivep/iOS 🍎t/bug :bug:up-for-grabs

Repository metrics

Stars
 (5,644 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Description

From https://github.com/xamarin/Xamarin.Forms/issues/2798#issuecomment-401423464

If you look at the toolbar meticulously, the centering would have to be corrected, as you can see on the screenshot. I know, xamarin forms is not intended to be a pixel perfect solution, but a discrepancy of 64 px is far away from pixel perfect. As this is immediately flashy for a detail-loving user, i would expect an correction.

2018-06-29_02-41-53

Steps to Reproduce

  1. Create a Xamarin Forms App
  2. Create a Page with 3 or more Toolbar Items that have images
  3. Run it on iOS 11 Simulator or iPhone

Expected Behavior

Toolbar items are centered

Actual Behavior

Toolbar items are not centered

Basic Information

  • Version with issue: 3.1.0
  • Last known good version: n/a

Contributor guide

Research direction
Inspect the iOS toolbar renderer (UIToolbar) to understand how items are positioned; possibly adjust Auto Layout constraints.
Tech stack
csharp
Domain
mobile
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Xamarin.FormsiOS developmentC#
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70