whatwg/html

More infinite/NaN handling for <canvas> API members

Closed

#1,844 opened on Sep 30, 2016

View on GitHubContributor guide
 (3 comments) (0 reactions) (0 assignees)HTML (2,520 forks)batch import
good first issueneeds teststopic: canvas

Repository metrics

Stars
 (7,654 stars)
PR merge metrics
 (Avg merge 42d 18h) (22 merged PRs in 30d)

Description

From https://github.com/whatwg/html/pull/1790#issuecomment-250752410:

@zcorpan The list given above doesn't look complete to me. It's missing:

  • shadowOffsetX
  • shadowOffsetY
  • shadowBlur
  • lineWidth
  • miterLimit
  • setLineDash
  • lineDashOffset

at first glance.

There might be more missing as this is from Firefox implementation which may not have everything implemented yet.

We also forgot to file a WPT issue.

Contributor guide

Research direction
Inspect the canvas specification for each listed property (shadowOffsetX, shadowOffsetY, shadowBlur, lineWidth, miterLimit, setLineDash, lineDashOffset) and verify if they correctly handle infinite and NaN values. Check the current browser implementations and any existing Web Platform Tests (WPT) for these properties. Add missing WPT tests and propose fixes to the HTML spec as needed.
Tech stack
javascripthtml
Domain
frontendweb dev
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
JavaScriptHTMLCanvas API
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60