whatwg/dom

Make "inner invoke" use "remove an event listener"

Closed

#651 opened on Jun 4, 2018

View on GitHubContributor guide
 (0 comments) (0 reactions) (0 assignees)HTML (338 forks)batch import
clarificationgood first issue

Repository metrics

Stars
 (1,728 stars)
PR merge metrics
 (Avg merge 56d 18h) (6 merged PRs in 30d)

Description

Even though it technically doesn't need to set the removed flag, it seems cleaner to use the same abstraction.

Contributor guide

Research direction
Identify the algorithm for 'inner invoke' and see how it sets the removed flag. Then adapt it to use the 'remove an event listener' abstraction.
Tech stack
javascript
Domain
api
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptEvent listeners
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80