vinitshahdeo/PortScanner

[BUG] Duplicate generated ports causing infinite loop

Open

#70 opened on Aug 17, 2020

View on GitHubContributor guide
 (3 comments) (0 reactions) (2 assignees)Python (122 forks)auto 404
CH20bugeasyhacktoberfest

Repository metrics

Stars
 (150 stars)
PR merge metrics
 (PR metrics pending)

Description

Describe the bug

The random ports generated in /server/utils/randomNum.js will have to pass duplicate port numbers to /server/index.js when high - low < countofPorts. This renders index.js file to enter infinite loop.

To Reproduce

Steps to reproduce the behavior:

  1. Go to /
  2. Edit config.json for range.high-range.low < count .
  3. Open terminal and run npm start
  4. See error (infinite loop)

Expected behavior

If the provided range is less than countofPorts, show error and display a message.

Contributor guide

Research direction
Examine the random number generation logic in `/server/utils/randomNum.js` and how it interacts with `/server/index.js`. Implement a check to compare the requested number of ports with the available range, and handle the insufficient range case by logging an error and stopping the process gracefully.
Tech stack
python
Domain
backendnetworking
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
PythonGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60