vinitshahdeo/PortScanner

The low & high range of ports in scanner.py is hardcoded

Open

#1 opened on Jun 4, 2020

View on GitHubContributor guide
 (6 comments) (0 reactions) (0 assignees)Python (122 forks)auto 404
beginner friendlyfirst-timers-onlygood first issuehelp wantedup for grabs

Repository metrics

Stars
 (150 stars)
PR merge metrics
 (PR metrics pending)

Description

Reading config.json and using range.low and range.high in scanner.py

The range for ports shouldn't be hardcoded. It should be ideally fetched from config.json as it's being used in server/index.js.

for port in range(1,8888):  
        sock = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
        result = sock.connect_ex((remoteServerIP, port))
        if result == 0:
            print "Port {}: 	 Open".format(port)
        sock.close()

Contributor guide

Research direction
Read the config.json file to obtain the low and high port range values, then replace the hardcoded range in scanner.py.
Tech stack
python
Domain
cli
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Python
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85