vimeo/psalm

Psalm doesn't notice session_unset()

Open

#9,198 opened on Jan 29, 2023

View on GitHubContributor guide
 (2 comments) (0 reactions) (0 assignees)PHP (668 forks)batch import
Help wantedeasy problemsenhancement

Repository metrics

Stars
 (5,369 stars)
PR merge metrics
 (Avg merge 3d 12h) (5 merged PRs in 30d)

Description

For example: https://psalm.dev/r/c1dc7af1fb

When the session is cleared by setting it to an empty array Psalm is aware that the key doesn't exist, but if the same is done using session_unset() Psalm doesn't notice this fact.

Contributor guide

Research direction
Investigate how Psalm tracks side effects of PHP functions and add a stub or handling for session unset to mark $ SESSION as cleared.
Tech stack
php
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitPHP
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75