vimeo/psalm

Improve support for is_file and family

Open

#7,770 opened on Mar 10, 2022

View on GitHubContributor guide
 (13 comments) (0 reactions) (0 assignees)PHP (668 forks)batch import
Help wantedeasy problemsenhancementgood first issueinternal stubs/callmap

Repository metrics

Stars
 (5,369 stars)
PR merge metrics
 (Avg merge 3d 12h) (5 merged PRs in 30d)

Description

Hi,

The functions that expect a valid path (file_exists, is_readable, ...) always return false when an empty string is provided ( https://3v4l.org/TcecN ). So when those functions return true we can say that the argument is a non-empty string.

If my assumption is right it could help with situations like this: https://psalm.dev/r/26f209fe21

Contributor guide

Research direction
Study Psalm's existing type inference for filesystem functions and modify to assume non empty string when file exists etc. return true.
Tech stack
php
Domain
developer experience
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
PHP
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60