A string after strlen > 0 check should be a non-empty-string

Repository metrics

Stars

5,369 stars (5,369 stars)

PR merge metrics

Avg merge 3d 12h (Avg merge 3d 12h)5 merged PRs in 30d (5 merged PRs in 30d)

Description

Contributor guide

Research direction

Examine the condition in Psalm's type system that handles `strlen($str) > 0` and ensure it narrows the type to `non empty string`. Check related code in `src/Psalm/Internal/Analyzer/Statements/Expression/BinaryOp/ComparisonAnalyzer.php` and `src/Psalm/Type/Reconciler.php`.

Tech stack

php

Domain

tooling

Issue type

Bug

DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.

2

Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.

1-3 hours

Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.

Active

ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.

Clear

Prerequisites

PHPGit

Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.

75