videojs/video.js

Html5 src behaves incorrectly

Open

#1,169 opened on Apr 25, 2014

View on GitHubContributor guide
 (15 comments) (0 reactions) (0 assignees)JavaScript (7,502 forks)batch import
bugconfirmedgood first issuepinnedunclaimed

Repository metrics

Stars
 (39,742 stars)
PR merge metrics
 (Avg merge 111d 10h) (3 merged PRs in 30d)

Description

If one calls player.src() the current code for Html5 media will actually overwrite the src on the video rather than appropriately return src or return currentSrc

Contributor guide

Research direction
Inspect the Html5 media source code, specifically the player.src() method, to understand why it overwrites the video src instead of returning it or currentSrc. Fix the behavior to appropriately return the src or currentSrc.
Tech stack
javascript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80