victorb/trymodule

Fix exec call to remove cache folder

Open

#15 opened on Mar 29, 2016

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (31 forks)github user discovery
enhancementhelp wanted

Repository metrics

Stars
 (1,133 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

https://github.com/VictorBjelkholm/trymodule/blob/2030806d790213d426456959fdc7a69773a4c6f7/index.js#L59

Oh noes. Please don't. Never do string concat for commands, use execFile instead. Never pass environment variables directly to rm without sanitation, better yet, never spawn rm. Use a JS tools, like rimraf or even better del.

From: https://github.com/sindresorhus/awesome-nodejs/pull/477#event-606502245

Contributor guide

Research direction
Replace the exec call with execFile or use rimraf to safely remove the cache folder.
Tech stack
javascript
Domain
cli
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Node.jsGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75