vesoft-inc/nebula-java

The storage leader address for the partition of metaManager cache does not look correct

Open

#354 opened on Sep 22, 2021

View on GitHub
 (3 comments) (2 reactions) (1 assignee)Java (126 forks)auto 404
good first issuetype/enhancementtype/question

Repository metrics

Stars
 (198 stars)
PR merge metrics
 (PR metrics pending)

Description

对应代码：https://github.com/vesoft-inc/nebula-java/blob/3518faa8444c1f590fba92d7f7c66946ad696852/client/src/main/java/com/vesoft/nebula/client/meta/MetaManager.java#L114

GetPartsAllocReq返回的分区信息无法确定哪个host是leader吧？代码取了第一个，对比 ListHosts 返回的 LeaderParts，第一个并不是 Leader Host。我是参考这里的 https://github.com/vesoft-inc/nebula-common/blob/master/src/common/clients/meta/MetaClient.cpp#L3189

另外 StorageClient 目前只有 scanXXX 接口，有无计划补全剩下的接口？

Contributor guide

Research direction
Inspect the GetPartsAlloc response handling in MetaManager.java and compare with the C++ client's method of determining the leader host. Trace the logic to see if the first host from GetPartsAlloc matches the leader from ListHosts.
Tech stack
java
Domain
backenddatabase
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Java
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75